From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Date: Wed, 06 Nov 2019 15:56:34 GMT
Subject: Re: [PATCH 2/5] doc: reset: unify <pathspec> description
Message-ID: <b7acd8d1-d17a-29bd-44d3-59d425842c10@syntevo.com>
In-Reply-To: <xmqqh83hveiz.fsf@gitster-ct.c.googlers.com>

I think I have implemented most suggestions in PatchV2. Thanks!

> Any time I see "... X. This means Y." either in the doc or in the
> proposed log message, I wish the author (not you in this case,
> obviously) thought twice about rewriting so that they do not say one
> thing and immediately have to rephrase it, i.e. either just say Y
> without saying X, or saying X more clearly without having to say Y.
> 
> In this case, however, I think X and Y are related but both relevant.
> The subcommand resets the index entries for chosen paths to match
> what is in the tree-ish, which is the same as restoring from a tree
> to the index.
> 
> It is not quite the opposite of adding to the index from the working
> tree.  In this sequence:
> 
> 	$ edit newfile
> 	$ git add newfile
> 
> and then further
> 
> 	$ edit newfile
> 	$ git add newfile
> 	$ git reset -- newfile
> 
> we are taken back to the state _before_ any of the changes made to
> newfile (in fact, since HEAD does not have newfile, the resulting
> index would not know about it, either).

I am a bit confused, is it correct that you don't expect me to change my 
patches?