From: David Turner <david.turner@twosigma.com>
Date: Fri, 30 Sep 2016 21:32:04 GMT
Subject: RE: [PATCH 3/6] tmp-objdir: introduce API for temporary object directories
Message-ID: <b7136f0690244aee94ff2db726a7edce@exmbdft7.ad.twosigma.com>
In-Reply-To: <20160930193613.dwpjiw5xps6a3wgj@sigill.intra.peff.net>

> +static void env_append(struct argv_array *env, const char *key, const
> +char *val) {
> +	const char *old = getenv(key);
> +
> +	if (!old)
> +		argv_array_pushf(env, "%s=%s", key, val);
> +	else
> +		argv_array_pushf(env, "%s=%s%c%s", key, old, PATH_SEP,
> val); 
>+}

I would like a comment explaining this function. 

> + * Finalize a temporary object directory by migrating its objects into
> +the main
> + * object database.
> + */

This should mention that it frees its argument.