From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Wed, 24 Sep 2025 07:24:57 GMT
Subject: Re: [PATCH v3 3/8] reftable: check for trailing newline in 'tables.list'
Message-ID: <b6d03748-8171-4df3-83fd-7f4025d9eb6c@app.fastmail.com>
In-Reply-To: <20250918-228-reftable-introduce-consistency-checks-v3-3-271af03eb34d@gmail.com>

On Thu, Sep 18, 2025, at 10:11, Karthik Nayak wrote:
> In the reftable format, the 'tables.list' file contains a newline
> separated list of tables. While we parse this file, we do not check or
> care about trailing newlines. Tighten the parser in `parse_names()` to
> return an appropriate error if there is no trailing newline.

Nit:[1] newline-separated + requiring a trailing newline sounds like it
really equals: newline-terminated list.  Is this moving from
effectively using newline-separated to a newline-terminated format?

† 1: Since others have commented anyway

>
> This requires modification to `parse_names()` to accept a third argument
> which will hold the error value.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---