From: David Turner <david.turner@twosigma.com>
Date: Thu, 23 Feb 2017 01:16:33 GMT
Subject: RE: [PATCH 2/2] http: add an "auto" mode for http.emptyauth
Message-ID: <b5778a7988ad4dfa9adfc8d312432189@exmbdft7.ad.twosigma.com>
In-Reply-To: <20170222234059.iajn2zuwzkzjxit2@sigill.intra.peff.net>

I don't know enough about how libcurl handles authentication to know whether 
these patches are a good idea, but I have a minor comment anyway.

> -----Original Message-----
> From: Jeff King [mailto:peff@peff.net]
> +static int curl_empty_auth_enabled(void) {
> +	if (curl_empty_auth < 0) {
> +#ifdef LIBCURL_CAN_HANDLE_AUTH_ANY
> +		/*
> +		 * In the automatic case, kick in the empty-auth
> +		 * hack as long as we would potentially try some
> +		 * method more exotic than "Basic".
> +		 *
> +		 * But only do so when this is _not_ our initial
> +		 * request, as we would not then yet know what
> +		 * methods are available.
> +		 */

Eliminate double-negative:

"But only do this when this is our second or subsequent request, 
as by then we know what methods are available."