From: Kaartic Sivaraam Date: Tue, 20 Feb 2018 19:36:38 GMT Subject: Re: [PATCH v2] Fix misconversion of gitsubmodule.txt Message-ID: In-Reply-To: Hi, On Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote: > Kaartic was the last to touch that file, > (as found via git log origin/master -- Documentation/gitsubmodules.txt), > sorry I did not find this in the review. > "Non-ASCII characters" made me dig into to this a little deeper as I generally don't use them particularly for text files. "git blame" points at d48034551 (submodules: overhaul documentation, 2017-06-22) as the offending comment. > Thanks for the patch! Yeah, nice catch! -- Kaartic QUOTE β€œIt is impossible to live without failing at something, unless you live so cautiously that you might as well not have lived at all – in which case, you fail by default.” - J. K. Rowling