From: Stefan Haller <stefan@haller-berlin.de>
Date: Mon, 23 Nov 2020 19:03:32 GMT
Subject: Re: [PATCH] git-gui: Fix selected text colors
Message-ID: <b4571217-ea98-a282-48d3-e9679c600f4c@haller-berlin.de>
In-Reply-To: <DZJ7KQ.UXACXR9SWDQI3@gmail.com>

On 22.11.20 18:16, serg.partizan@gmail.com wrote:
> I think calculating that gray color from current selection bg is too
> much work for just one color.
> 
> We can just set inactiveSelectBackground to some neutral gray color like
> #707070 or #909090 which will work fine with both dark and light themes.

I tested this, but it doesn't work well enough, in my opinion. An
#888888 gray is too dark for normal mode, but too bright for dark mode
on Mac.

Calculating a gray color is not really so difficult, so I'll just do
that in v2. The problem is that it needs to be recalculated when the
theme changes, and I have trouble testing that because the
<<ThemeChanged>> event doesn't appear to be sent on Mac, as far as I can
see.

-Stefan