From: René Scharfe <l.s.r@web.de>
Date: Fri, 09 Aug 2019 18:01:42 GMT
Subject: Re: [PATCH v2 5/7] quote: add sq_quote_argv_pretty_ltrim
Message-ID: <b3cf1b32-9e80-c9c5-ac9c-33f68ef8909d@web.de>
In-Reply-To: <5651286b-cd28-68ba-4743-98d546dfa3b0@jeffhostetler.com>

Am 09.08.19 um 19:13 schrieb Jeff Hostetler:
> On 8/8/2019 6:49 PM, René Scharfe wrote:
>>   void sq_quote_argv_pretty(struct strbuf *dst, const char **argv)
>>   {
>> -    int i;
>> -
>> -    for (i = 0; argv[i]; i++) {
>> -        strbuf_addch(dst, ' ');
>> -        sq_quote_buf_pretty(dst, argv[i]);
>> -    }
>> +    strbuf_addch(dst, ' ');
>
> If I'm reading this correctly, this has slightly different behavior
> than the original version.  Perhaps:
>
>     if (argv[0])
>         strbuf_addch(dst, ' ');

Oh, yes, thanks for spotting this.

René