From: Philip Oakley Date: Thu, 04 Jul 2019 10:40:33 GMT Subject: Re: [PATCH] make slash-rules more readable Message-ID: In-Reply-To: On 27/06/2019 18:10, Dr. Adam Nielsen wrote: > > On 25.06.19 13:31, Philip Oakley wrote: >> only one minor point... > > >>> + - For example, a pattern `doc/frotz/` matches `doc/frotz` > directory, > >>> +   but not `a/doc/frotz` directory; however `frotz/` matches `frotz` > > > > her I misread this as:  "but not a `doc/frotz` directory;" > > i.e. the leading 'a' is too easy to skim over as is part of the > > sentence's prose, so maybe change to a 'baz' lead directory (bar > already > > having been used below). > > Yes we could change that. > >> Have you tried it out on any StackOverflow replies to see if those >> that inhabit that zone find it helpful? >> Philip > I answered one person who had a hard time reading the docs at SO, but > he didn't respond and the last time he was online was 2018, so I > didn't made the effort to edit my answer with the current version. > > - > > What are the next steps? If there are no more responses, does it imply > that everyone agrees with this patch? Can we publish it online? > If all the issues are cleared then I believe it is a case of providing a clean reroll (maybe identical to previous..) to Junio and the list to confirm that all issues have been resolved and it is ready for pu->next->master in the normal way, which should then show up in his 'What's cooking' emails.