From: Phillip Wood Date: Thu, 20 Jun 2019 09:34:53 GMT Subject: Re: pw/rebase-abort-clean-rewritten, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14) Message-ID: In-Reply-To: Hi Junio & dscho On 18/06/2019 04:30, Junio C Hamano wrote: > Phillip Wood writes: > >> Yes I sent it just before I went offline, but that's a while ago now > > Yup. IIRC, you told us not to look at the patch "for now" as you > would be offline, and I was fully expecting that a regular review > exchange would happen after you come back. > > I do not recall seeing much discussion, though, but ... You're right there hasn't been much discussion I assume dscho is happy with the new version if he's asking for it to be picked up. >>> Phillip, I was under the impression that all reviewer comments had been >>> resolved. Does that match your impression? >> >> Yes, I think it's ready. Thanks for prompting me dscho, I'd seen this >> was on hold and then forgotten to write to Junio > > ... if you resolved "all reviewer comments", it must have seen > sufficient review, in which case let's merge it to 'next'. Thanks Phillip > Thanks. >