From: Mark Levedahl <mlevedahl@gmail.com>
Date: Sun, 25 Jun 2023 11:28:16 GMT
Subject: Re: [PATCH v0 0/4] Remove obsolete Cygwin support from git-gui
Message-ID: <b290eac3-e07b-aa0d-593e-c9f8abed8826@gmail.com>
In-Reply-To: <xmqq4jmw77sk.fsf@gitster.g>


On 6/24/23 19:35, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> patch 1 removes the obsolete Makefile code
>>> patch 2 removes all obsolete git-gui.sh code, wrapped in is_Cygwin...
>> As it has been quite a while since I had access to any Windows box
>> or Cygwin, but the earlier two patches look obviously correct to me.
> Ehh, in an early draft, I had "I cannot comment on patches #3 and
> #4" before that "but", but I ended up commenting on them anyway, and
> ended up with such a garbled construction.  I should have copyedited
> the above to "Even though it has been ... or Cygwin, the earlier...".
>
> Sorry for the noise.

No problem, I appreciate the review. The last two patches absolutely 
need the Cygwin / G4W folks to review.


Mark