From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Wed, 12 Sep 2018 02:25:52 GMT
Subject: Re: [PATCH 6/9] submodule.c: do not copy around submodule list
Message-ID: <b16af8c0-0435-0de4-ed6c-53888d6190af@ramsayjones.plus.com>
In-Reply-To: <20180911234951.14129-7-sbeller@google.com>



On 12/09/18 00:49, Stefan Beller wrote:
> 'calculate_changed_submodule_paths' uses a local list to compute the
> changed submodules, and then produces the result by copying appropriate
> items into the result list.
> 
> Instead use the result list directly and prune items afterwards
> using string_list_remove_empty_items.
> 
> By doin so we'll have access to the util pointer for longer that

s/doin/doing/

ATB,
Ramsay Jones