From: Jeff Hostetler <git@jeffhostetler.com>
Date: Fri, 30 Apr 2021 14:33:49 GMT
Subject: Re: [PATCH 06/23] fsmonitor--daemon: implement client command options
Message-ID: <b0fe4d10-1205-39e4-72c9-d33d1f023730@jeffhostetler.com>
In-Reply-To: <098e4123-676e-2ea0-4c16-dbeaa1198b46@gmail.com>



On 4/26/21 11:12 AM, Derrick Stolee wrote:
> On 4/1/21 11:40 AM, Jeff Hostetler via GitGitGadget wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Implement command options `--stop`, `--is-running`, `--query`,
>> `--query-index`, and `--flush` to control and query the status of a
>> `fsmonitor--daemon` server process (and implicitly start a server
>> process if necessary).
>>
>> Later commits will implement the actual server and monitor
>> the file system.
> 
> As mentioned before, I think the "query", "query-index", and
> "flush" commands are better served in a test helper. Luckily,
> the implementation you give here seems rather straightforward
> and could fit into a test helper without a lot of duplicated
> boilerplate. That's a good sign for the API presented here.
> 
> As a bonus, you could delay the implementation of those test
> helpers until they are going to be used in a test.
> 
> Thanks,
> -Stolee
> 

Good point.  I'll take a look at this.

Thanks
Jeff