From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Sun, 14 Sep 2008 21:01:55 GMT
Subject: Re: [StGit PATCH] Do not crash if a patch log ref is missing
Message-ID: <b0943d9e0809141401o36b1347ctf6444a695b74a8b7@mail.gmail.com>
In-Reply-To: <20080914080839.GA30664@diana.vm.bytemark.co.uk>

On 14/09/2008, Karl Hasselström <kha@treskal.com> wrote:
> On 2008-09-12 22:54:58 +0100, Catalin Marinas wrote:
>
>  > Since we'll get rid of the individual patch logs, StGit should
>  > ignore if such a ref is missing when deleting the compatibility
>  > patch files.
>
>
> I agree this is a good idea from a robustness perspective. Did you
>  encounter a case where the deletion actually failed?

Yes, I was deleting some older patches and it happened for one of them
not to have a log reference. It left the stack in a pretty undefined
state (and used the stable StGit to delete the rest of the patches as
it is more tolerant :-)).

-- 
Catalin