From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Sun, 29 Jun 2008 09:42:32 GMT
Subject: Re: [StGit PATCH 1/2] Convert "stg refresh" to the new infrastructure
Message-ID: <b0943d9e0806290242q1bc8aa67qb3523221b3db70e2@mail.gmail.com>
In-Reply-To: <20080625042337.6044.53357.stgit@yoghurt>

2008/6/25 Karl Hasselström <kha@treskal.com>:
> And in the process, make it more powerful: it will now first create a
> temp patch containing the updates, and then try to merge it into the
> patch to be updated. If that patch is applied, this is done by
> popping, pushing, and coalescing; if it is unapplied, it is done with
> an in-index merge.

Does it make sense to refresh an unapplied patch? Maybe adding a new
file to the patch but I don't really see a need for this.

> Also, whenever path limiting is used, we will now use a temporary
> index in order to avoid including all staged updates (since they may
> touch stuff outside the path limiters).

I haven't checked but what is the behaviour in subdirectors? It
currently refreshes everythink unless "." is specified so that it will
only refresh the current subdirectory.

The patch looks fine otherwise.

-- 
Catalin