From: Catalin Marinas Date: Thu, 05 Jun 2008 11:46:01 GMT Subject: Re: [StGIT PATCH 1/5] Allow stack.patchorder.all to return hidden patches Message-ID: In-Reply-To: <20080605064152.GA23209@diana.vm.bytemark.co.uk> 2008/6/5 Karl Hasselström : > On 2008-06-04 22:13:17 +0100, Catalin Marinas wrote: >> if bad: >> raise common.CmdException('Bad patch names: %s' > > Forbidding commit to operate on hidden patches? OK, why not? But > saying "Bad patch name" if the user gives a hidden patch is probably a > bit on the grumpy side ... :-) OK. Changed it to "Nonexistent or hidden patch names". Could be done better but I wouldn't bother too much with this error. -- Catalin