From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Thu, 11 Oct 2007 20:42:20 GMT
Subject: Re: [StGit PATCH 09/13] Clear up the semantics of Series.new_patch
Message-ID: <b0943d9e0710111342j659a8e0byc2f022e59f6ea305@mail.gmail.com>
In-Reply-To: <87prznxvmq.fsf@lysator.liu.se>

On 10/10/2007, David Kågedal <davidk@lysator.liu.se> wrote:
> "Catalin Marinas" <catalin.marinas@gmail.com> writes:
> > On 08/10/2007, Karl Hasselström <kha@treskal.com> wrote:
> >> Couldn't "stg pick --reverse" create a new commit and use that? That
> >> is, given that we want to revert commit C, create a new commit C* with
> >
> > Series.new_patch already creates a commit, why should we move the
> > functionality to 'pick'? The only call to new_patch with commit=False
> > seems to be from 'uncommit' (and it makes sense indeed).
>
> It might be true that the assertion could be amended so that if
> commit=True, then it is allowed to have top/bottom that doesn't
> correspond to a commit and its parent.

I'll fix this and add a test for pick --reverse.

-- 
Catalin