From: Catalin Marinas Date: Thu, 23 Aug 2007 14:04:02 GMT Subject: Re: [StGIT PATCH 2/2] Don't touch ref files manually Message-ID: In-Reply-To: <20070821164629.GB17045@diana.vm.bytemark.co.uk> On 21/08/07, Karl Hasselström wrote: > On 2007-08-21 14:23:29 +0100, Catalin Marinas wrote: > > > Thanks for this patch. > > Two things: > > * The test in your tree has the latin1 form of my name in it, > instead of utf8. (I noticed because I got a conflict when I > rebased onto your master.) I imported it on a different PC (at work) where I think the locale support isn't properly set up. Xterm accepted a copy-paste operation with your name and I passed it through emacs which probably broke it. The From: header had a different encoding and hence the author was correct. I'll try to do it on my home PC only (or just pull from your repo :-)). > * The test suite now fails on your master (since you've applied just > the test and not the fix). Please don't do that; it makes > development needlessly hard. (To be fair, this is partly my fault, > since I posted the fixin a separate patch. I'll change my ways.) I think it's OK to send separate patches and I'm OK with a test failing in a development stage. The 2nd patch didn't apply cleanly and didn't have time to see what was wrong. I'll push it tonight, please have a look for things I might have missed. Thanks. -- Catalin