From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Wed, 06 Dec 2006 13:12:53 GMT
Subject: Re: "stgit clean" has problems with removed generated files
Message-ID: <b0943d9e0612060512w272d656dwa3ef5b6875abf8fa@mail.gmail.com>
In-Reply-To: <20061123192831.GL5443@nan92-1-81-57-214-146.fbx.proxad.net>

On 23/11/06, Yann Dirson <ydirson@altern.org> wrote:
> On Thu, Nov 23, 2006 at 04:33:42PM +0000, Catalin Marinas wrote:
> > >First, when cleaning patches, we could first look up which patches are
> > >to be removed, and only pop the necessary ones.

I fixed this.

> > Is there any other place where ranges could be used but aren't?
>
> Hm, let's see...  I'd say "export" (I have missed it already), "files"
> and maybe "commit" and "pick", although the latter would require a syntax
> for ranges in other branch.

I changed the export command to take a range of patches as arguments
(and a --dir option for the export directory).

> While reviewing the various commands for this, I realized that "stg pop
> <patch>" semantics is significantly different from "stg push <patch>" -
> ie. it is an equivalent of "goto".  What about turning it into a
> float+pop, to better match the "push" behaviour ?

Thanks for the suggestion, I fixed pop to take patch ranges now.

> I also realized that "stg help <command>" output does not go through to
> the pager, while eg. the help for "mail" is quite long.

Added this feature as well. I'll try to push the changes tonight.

--