From: Catalin Marinas Date: Tue, 05 Dec 2006 17:30:56 GMT Subject: Re: [PATCH 1/3] Document some current bugs and add to the TODO list. Message-ID: In-Reply-To: <20061130002717.21981.38049.stgit@gandelf.nowhere.earth> Hi Yann, See some comments below (I removed those which I am OK with or I fixed). On 30/11/06, Yann Dirson wrote: > +- numeric shortcuts for naming patches near top (eg. +1, -2) We currently have the -n option for push and pop that accepts number. Because of python, you can also, for example, push to the last but one with "push -n -1" (similar for pop). Do you mean shortcuts for the "goto" command? > +- refuse to "stg init" a branch known as remote (through .git/remotes/, > + .git/branches/ or any other info) I think it is up to the user not to do this. You would first need to check out such a branch anyway. > +- cannot use "stg refresh file" after "cg-rm file" It seems to work for me. Can you send some log messages? > +- "stg goto $(stg top)" fails with unhandled exception It works for me. What StGIT version do you use? > +- at least "commit is not robust wrt out-of-diskspace condition: > +|deps$ stg commit > +|error: git-checkout-index: unable to write file MANIFEST > +|error: git-checkout-index: unable to write file META.yml > +|error: git-checkout-index: unable to write file Makefile.PL > +|error: git-checkout-index: unable to write file doc/README.dbk.xml > +|error: git-checkout-index: unable to write file graph-includes > +|error: git-checkout-index: unable to write file lib/graphincludes/params.pm > +|fatal: unable to write new index file > +|stg commit: git-read-tree failed (local changes maybe?) > +|Committing 4 patches... > +(luckily nothing was really committed) But that's the correct behaviour, not to commit anything. The only problem I see (and I fixed) is the "Committing..." message on stdout without flushing, causing it to appear afterwards. StGIT cannot know how much space is needed by GIT to check this beforehand. It simply exits when a GIT command failed. Thanks. --