From: Catalin Marinas Date: Sun, 20 Aug 2006 10:43:22 GMT Subject: Re: [PATCH 2/2] Look for a commit's parents in the standard way. Message-ID: In-Reply-To: <20060814165544.20350.41590.stgit@gandelf.nowhere.earth> On 14/08/06, Yann Dirson wrote: > This has the direct effect of taking info/grafts into account, since > ignoring it only causes confusion. I don't know the difference but is there any between parsing the commit file and using git-rev-list --parents? > + self.__parents = split(_output_lines('git-rev-list --parents --max-count=1 %s' % id_hash)[0])[1:] Instead of using the split() method, you could call _output_lines('git-rev-list --parents --max-count=1 %s' % id_hash)[0].split()[1:]. Maybe that's why they might deprecate the global split method. Setting self.__parents by calling get-rev-list would have a performance impact on the push operation. I think we could remove the __parents variable and only call git-rev-parse in get_parents() or get_parent(). -- Catalin