From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Thu, 01 Dec 2005 21:05:32 GMT
Subject: Re: [PATCH 6/7] Add a "--clone" option to "stg branch"
Message-ID: <b0943d9e0512011305v3299f27au@mail.gmail.com>
In-Reply-To: <20051129220949.9885.51533.stgit@dexter.citi.umich.edu>

On 29/11/05, Chuck Lever <cel@netapp.com> wrote:
> Cloning a branch means creating a new branch and copying all of the
> original branch's patches and its base to it.  Like creating a tag,
> but this also preserves all the StGIT patches as well.
[...]
> --- a/stgit/commands/branch.py
> +++ b/stgit/commands/branch.py
[...]
> +        print 'Cloning current branch to "%s"...' % clone

I would put a comma after this line and add sys.stdout.flush(). So
that 'done' is shown on the same line.

[...]
> --- a/stgit/stack.py
> +++ b/stgit/stack.py
[...]
> +    def clone(self, target_series):
> +        """Clones a series
> +        """

Wouldn't it be easier to do a recursive copy at the directory level
(.git/patches/<branch> into .git/patches/<clone> and
.git/refs/bases/<branch> into .git/refs/bases/<clone>)? Is there
anything that could go wrong if we do this?

--
Catalin