From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 28 Oct 2025 18:42:34 GMT
Subject: Re: [PATCH v2 10/10] receive-pack: convert receive hooks to hook API
Message-ID: <b03a96a8-af42-427a-8cf1-4d195be6a7c7@app.fastmail.com>
In-Reply-To: <20251017141544.1538542-11-adrian.ratiu@collabora.com>

On Fri, Oct 17, 2025, at 16:15, Adrian Ratiu wrote:
> From: Emily Shaffer <emilyshaffer@google.com>
>
> This converts the last remaining hooks to the new hook API, for
> the same benefits as the previous conversions (no need to toggle
> signals, manage custom struct child_process, call find_hook(),
> prepares for specifyinig hooks via configs, etc.).
>
> I noticed a performance degradation when processing large amounts
> of hook input with just 1 line per callback, due to run-command's
> ppoll loop, therefore I batched 500 lines per callback, to ensure

I don’t see `ppoll` in `run-command.c`.

> similar pipe throughput as before and to avoid hook child waiting
> on stdin.
>
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---