From: Brandon Casey Date: Mon, 22 Sep 2008 23:19:05 GMT Subject: [PATCH bc/maint-diff-hunk-header] t4018-diff-funcname: test syntax of builtin xfuncname patterns Message-ID: In-Reply-To: <7vy71n482x.fsf@gitster.siamese.dyndns.org> Signed-off-by: Brandon Casey --- How about something like this on top of your ERE conversion patch. It will test that regcomp() completes successfully. -brandon t/t4018-diff-funcname.sh | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh index 602d68f..76919a4 100755 --- a/t/t4018-diff-funcname.sh +++ b/t/t4018-diff-funcname.sh @@ -32,7 +32,18 @@ EOF sed 's/beer\\/beer,\\/' < Beer.java > Beer-correct.java +builtin_patterns="bibtex java pascal ruby tex" +for p in $builtin_patterns +do + test_expect_success "builtin $p pattern compiles" ' + echo "*.java diff=$p" > .gitattributes && + git diff --no-index Beer.java Beer-correct.java 2>&1 | + test_must_fail grep "fatal" > /dev/null + ' +done + test_expect_success 'default behaviour' ' + rm -f .gitattributes && git diff --no-index Beer.java Beer-correct.java | grep "^@@.*@@ public class Beer" ' -- 1.6.0.1.244.gdc19