From: Patrick Steinhardt Date: Tue, 10 Nov 2026 16:40:22 GMT Subject: Re: [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY Message-ID: In-Reply-To: On Tue, Nov 10, 2026 at 08:13:39AM -0800, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > All I'm pointing out is that there are cases where we could be as > > defensive as everywhere else if we started passing down the options to > > calling contexts that don't have it yet. > > OK, that does make sense, but I suspect the current helper functions > that do not get unpack_opt do not because they do not have a reason > to access anything in it. We could throw "struct repository *" into > that struct and use that one (ignoring the one in the istates). > > I however think that would be a separate clean-up. Yup, that's reasonable. Thanks! Patrick