From: Patrick Steinhardt Date: Tue, 10 Nov 2026 06:53:11 GMT Subject: Re: [PATCH v2 4/7] t0027: optimize how we reset repository state Message-ID: In-Reply-To: On Mon, Nov 09, 2026 at 08:59:39AM -0800, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh > > index 49dbf09da77..504a7ea54bb 100755 > > --- a/t/t0027-auto-crlf.sh > > +++ b/t/t0027-auto-crlf.sh > > @@ -305,11 +305,12 @@ checkout_files () { > > A micronit. > > > pfx=eol_${ceol}_crlf_${crlf}_attr_${attr}_ && > > for f in LF CRLF LF_mix_CR CRLF_mix_LF LF_nul > > do > > - test_expect_success "setup $f checkout ${ceol:+ with -c core.eol=$ceol}" ' > > - rm -f crlf_false_attr__$f.txt && > > - git ${ceol:+-c core.eol=$ceol} checkout -- crlf_false_attr__$f.txt > > - ' > > + paths="${paths:+"$paths "}crlf_false_attr__$f.txt" > > done > > We may know that nobody has touched variable "$paths" elsewhere in > this program, but I would prefer to have an explicit "let's start > with an empty $paths" assignment very close to this loop to help > future readers. That way they do not have to wonder and look all > over to find out after what string we are appending these filenames. Yeah, makes sense. Patrick