From: Patrick Steinhardt Date: Wed, 18 Nov 2026 12:05:31 GMT Subject: Re: [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Message-ID: In-Reply-To: On Wed, Nov 18, 2026 at 03:28:25AM -0800, Karthik Nayak wrote: > Patrick Steinhardt writes: > > diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c > > index 3ba6a9ac0db..4216a18684d 100644 > > --- a/refs/reftable-backend.c > > +++ b/refs/reftable-backend.c > > @@ -2706,6 +2706,11 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store, > > if (flags & EXPIRE_REFLOGS_UPDATE_REF && last_hash && !is_null_oid(&oid)) > > oidread(&arg.update_oid, last_hash, ref_store->repo->hash_algo); > > > > + if ((flags & EXPIRE_REFLOGS_DRY_RUN)) { > > + ret = 0; > > + goto done; > > + } > > + > > arg.refs = refs; > > arg.records = rewritten; > > arg.len = logs_nr; > > @@ -2720,8 +2725,7 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store, > > * Future improvement: we could skip writing records that were > > * not changed. > > */ > > This comment doesn't seem to get removed in the following patch. That's because I don't fully consider this comment to be addressed. If I understand correctly, this also speaks about the fact that we could drop rewriting entries in a finer-grained way. All I'm changing is that we now don't write any entries in case none of them need to be rewritten. Patrick