From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 03 Nov 2026 10:23:30 GMT
Subject: Re: [PATCH 0/4] mark symbols that are unnecessarily public static
Message-ID: <aum2IssjPCGMySLm@pks.im>
In-Reply-To: <20261030182648.GE7582@coredump.intra.peff.net>

On Fri, Oct 30, 2026 at 02:26:48PM -0400, Jeff King wrote:
> On Fri, Oct 30, 2026 at 10:39:52AM -0700, Junio C Hamano wrote:
> 
> > Over the years, refactoring various subsystems, adding new callers,
> > and rewriting them from scratch, made some symbols that started as
> > static into global, and some other symbols that started as global,
> > no longer need to be visible outside a file that use them.  Here is
> > a small patch series that turns them back into file-scope static.
> > 
> > Honestly, I suspect that [3/4] was probably better with a forward
> > declaration in the preview I sent earlier, but in the longer term,
> > readers would not care if this conversion ended up in a large code
> > movement, as they do not have to even know it.
> 
> The subject for patch 1 caught my eye, but I eyeballed the whole series
> and they all look reasonable to me. I agree that big code movement is
> sometimes annoying in a diff, but the flip side is that the resulting
> file is nicer to read and maintain.

Yup, I'm happy, as well. There's two tiny nits on the commit messages,
but nothing that'd really need a reroll.

Thanks!

Patrick