From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 03 Nov 2026 10:27:03 GMT
Subject: Re: [Outreachy PATCH v2 0/2] notes-utils: stop using the_repository
Message-ID: <aum29zvhcsj41yHz@pks.im>
In-Reply-To: <CAOLa=ZTAEVcKj-Y5QCGsAFAMUSh665E1fmQrEnuuufTLLbn3Wg@mail.gmail.com>

On Tue, Nov 03, 2026 at 03:48:01AM -0600, Karthik Nayak wrote:
> Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
> 
> > This series removes the_repository from notes-utils.c.
> >
> > Changes since v1:
> > - Add patch 2, which passes a repository to
> >   init_copy_notes_for_rewrite() and drops USE_THE_REPOSITORY_VARIABLE
> >   from notes-utils.c, as Patrick suggested. v1 stopped one step short
> >   of that.
> >
> > The callers in builtin/am.c and builtin/notes.c pass the_repository,
> > as those files still use it everywhere. copy() in builtin/notes.c
> > does receive a repo that could be passed down instead, if that is
> > preferred.
> >
> > Thanks, Patrick, for the review.
> >
> 
> Overall the patches look good to me.

Agreed, the patches look good to me, too.

Patrick