From: Patrick Steinhardt Date: Mon, 02 Nov 2026 14:31:33 GMT Subject: Re: [PATCH v3] object-name: explain why ~N fails in a shallow clone Message-ID: In-Reply-To: On Mon, Nov 02, 2026 at 03:07:10PM +0100, Harald Nordgren wrote: > On Mon, Nov 2, 2026 at 1:25 PM Patrick Steinhardt wrote: > > > > On Mon, Nov 02, 2026 at 12:07:29PM +0100, Harald Nordgren wrote: > > > > > Is it possible that maybe the review process needs to change if too > > > > > many things are getting stuck? > > > > > > > > The regular reviewers have been talking about review work being scarce > > > > compared to contributions (contributor work) for at least several years > > > > now. How can this be changed if there simply aren’t enough people to > > > > review everything? > > > > > > We can loosen the requirements on perfect code, as long as it does > > > what it's supposed to and doesn't have security backdoors. > > > > > > Many things like tests, leaks and linting are already handled > > > automatically by GitHub CI. It's a good time investment to automate > > > more, because it frees up resources long-term. > > > > Even if we automate more of it, that would still not fix our bottleneck. > > I do no trust automated reviews enough to just merge patches without a > > human review, as part of the review is also the conceptual direction > > that we are moving towards. And that can only really be reviewed by > > someone who is familiar with the project overall. > > I'm not primarily talking about the review part, but about the > mechanical aspects around reviewing: > > You might point out that while the tip a series builds and tests pass, > a commit has a test added before the actual logic was added in the > subsequent commit. This is a class of problems that we can find with > automatic tooling, and then the human reviewers can free up more of > their scarce time for actual reviewing. Yeah, I agree that providing tooling that allows us to automatically verify some aspects that would typically be covered during code review would be good. It would probably need to come in the form of scripts that can be self-executed though as we don't have enough computing resources to execute such scripts. Ideally, we'd also commit to a cetrain machine-verifiable coding style so that it can be auto-verified, as well. But the discussions around clang-format never really led anywhere, unfortunately. > > Now automation could of course still help us. For example, if > > contributors started to self-review their patch series before sending > > them out, or if we had a tool like Sashiko [1]. If so, the human review > > would happen on a patch series that is in a better shape already, and > > that would likely require less of a time investment overall. > > > > [1]: https://sashiko.dev/ > > Interesting if Linux is using that. Linux is our sister project right? ;) Yup. I've been chatting with Roman briefly about this project and the possibility of adapting it to cover Git, as well. He was quite positive and mentioned that Google might even sponsor the infrastructure required for it. I haven't yet found the time to investigate more though, but I would be happy to have such tooling in Git. It shouldn't be mandatory, and in the beginning it might just be the web interface. But if it works well enough it could even eventually be updated to send review responses to the mailing list directly. > > Granted, at times we err too much on the side of polishing the last tiny > > nits. But quite often that's also us trying to train newcomers to write > > proper commit histories in the first place. > > Yes, this is a bigger issue than I think we understand. > > The Pareto principle (80/20) generally holds for things like this, and > maybe the last X% of code improvement is not worth the (100-X)% time > investment? For sure it's not linearly distributed. I guess that part of the problem is also that a shallow review that focusses on stylistic issues is way easier to do compared to one that does a deep dive into the underlying principles. It's simply a time tradeoff that reviewers need to do. That does not mean that those are meaningless though. As said, the benefit is also in that it allows newcomers to learn, both on the contributing and on the reviewing side. Patrick