From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 02 Nov 2026 11:01:38 GMT
Subject: Re: [Outreachy PATCH] notes-utils: use the passed repository for notes refs
Message-ID: <auhtiZ86trLamccS@pks.im>
In-Reply-To: <20261031104526.46711-1-okhuomonajayi54@gmail.com>

On Sat, Oct 31, 2026 at 11:45:26AM +0100, Okhuomon Ajayi wrote:
> create_notes_commit() and commit_notes() receive a repository,
> but read and update the notes ref in the_repository.
> 
> Use the repository they are given.
> 
> Keep USE_THE_REPOSITORY_VARIABLE because
> init_copy_notes_for_rewrite() still uses the_repository.

I don't quite understand patches like this. They are _so_ close to
getting rid of `USE_THE_REPOSITORY_VARIABLE`, but then they just skip on
the final change that would make them work. I've already asked about
this on one of your preceding patches.

Also, could you maybe reduce the frequency a bit with which you send new
topics? There's a ton of in-flight patch series by you in this vicinity,
and it gets a bit overwhelming. May I ask you to maybe batch related
patches into bigger series (maybe 5-10 commits) so that the reviewer can
focus on way fewer patch series overall, and then have less series in
flight at the same point in time?

Thanks!

Patrick