From: Justin Tobler <jltobler@gmail.com>
Date: Fri, 30 Oct 2026 15:31:17 GMT
Subject: Re: [PATCH v3 2/4] loose: lift loose object index parsing logic into helper
Message-ID: <auS3XTwBDP004Gc9@denethor>
In-Reply-To: <CAOLa=ZTNCcRCFDvUunqEqQCmDPE_2iu=rC4FwNmKAQujegC1Yg@mail.gmail.com>

On 26/10/30 07:50PM, Karthik Nayak wrote:
> Justin Tobler <jltobler@gmail.com> writes:
> 
> > diff --git a/loose.c b/loose.c
> > index c6f4ee0ec6..5f72c644f9 100644
> > --- a/loose.c
> > +++ b/loose.c
> > @@ -48,67 +48,88 @@ static int insert_oid_pair(kh_oid_map_t *map, const struct object_id *key, const
> >  	return 1;
> >  }
> >
> > -static int insert_loose_map(struct odb_source_loose *loose,
> > +static int insert_loose_map(struct loose_object_map *map,
> > +			    struct oidtree *cache,
> >  			    const struct object_id *oid,
> >  			    const struct object_id *compat_oid)
> 
> Nit: with the introduction of `loose_object_map_read()`, perhaps makes
> sense to keep naming consistent and rename this to
> `loose_object_map_insert()`?

I don't feel too strongly either way and am not sure this by itself it
worth a reroll. I'll keep it as-is for now.

-Justin