From: Patrick Steinhardt Date: Fri, 30 Oct 2026 09:38:04 GMT Subject: Re: [PATCH] add -i: hide init/clear_add_i_state() functions Message-ID: In-Reply-To: On Wed, Oct 28, 2026 at 12:57:51PM -0700, Junio C Hamano wrote: > The "add -i" machinery is encapsulated in run_add_i() function, > which uses init_add_i_state() to initialize the machinery, does its > thing, and clear_add_i_state() to tear it down. External callers > have no need to call anything other than run_add_i(). > > Make init/clear_add_i_state() file-scope static functions, and > "struct add_i_state" type as well. Nice cleanup. For historical context, these declarations are not needed anymore starting with d51b61f5dab (add-patch: remove dependency on "add-interactive" subsystem, 2026-03-02). Thanks! Patrick