From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 29 Oct 2026 12:12:05 GMT
Subject: Re: [PATCH v3] [Outreachy PATCH] t0001: avoid pipes in test scripts
Message-ID: <auM4FazXNNwLzM3-@pks.im>
In-Reply-To: <pull.2260.v3.git.1792732388827.gitgitgadget@gmail.com>

On Fri, Oct 23, 2026 at 05:13:08AM +0000, Srujith A Poojary via GitGitGadget wrote:
> From: Srujith Poojary <poojarysrujith@gmail.com>
> 
> Avoid piping output from git version directly into sed to ensure
> 
> that any command failure is properly caught by test scripts.

Formatting of your commit message is off a bit with an empty line in
the middle of the sentence.

> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f271..c8c74f681b 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -678,7 +678,8 @@ test_expect_success 'default ref format' '
>  		sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
>  		git init refformat
>  	) &&
> -	git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
> +	git version --build-options >build-options &&
> +	sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
>  	git -C refformat rev-parse --show-ref-storage-format >actual &&
>  	test_cmp expect actual
>  '

The changes look good to me though. Thanks!

Patrick