From: Patrick Steinhardt Date: Wed, 28 Oct 2026 07:26:06 GMT Subject: Re: [PATCH] pack-objects: handle missing objects kkkjwhen excluding promisor objects Message-ID: In-Reply-To: <03704f3590183aadc16d5d81bdc64e9a@fastmail.com> On Tue, Oct 27, 2026 at 12:02:11PM -0400, Mark C. Chu-Carroll wrote: > > On Tue, 27 Oct 2026 08:00:28 +0100, Patrick Steinhardt wrote: > > In a partial clone Git tries to maintain two different sets of objects: > > promisor objects should be those that we have received from the remote, > > and any such object may not be fully connected. Locally created objects > > on the other hand should be stored as non-promisor objects. The goal is > > that promisor objects should never reference non-promisor objects as the > > "promisor" property is contagious, where a promisor implicitly means > > that any of its referenced objects are promisor objects, too. > > Wordsmithing nitpick: this reads awkwardly. You start by saying there > are two different kinds of things, and then introduce one of them, > followed by a comma, followed by something which _isn't_ the second > type of thing. > > Maybe: > In a partial clone, Git tries to maintain two different sets of objects: > promisor objects (which are those we have recieved from a remote, and may > not be fully connected), and non-promisor objects (including any locally > created objects). The goal is that .... That reads better indeed. Queued locally for now, I'll wait a bit longer before sending this out. Thanks! Patrick