From: Patrick Steinhardt Date: Wed, 28 Oct 2026 07:08:26 GMT Subject: Re: [PATCH v2 5/6] odb/source-files: avoid stat'ing already-known alternates Message-ID: In-Reply-To: On Tue, Oct 27, 2026 at 03:31:43PM +0100, Christian Couder wrote: > On Tue, Oct 27, 2026 at 2:14 PM Patrick Steinhardt wrote: > > > > On Tue, Oct 27, 2026 at 01:36:35PM +0100, Christian Couder wrote: > > > > Does avoiding the syscall means not printing the "object directory %s > > > does not exist" error then, when we know the alternates but its > > > directory was removed? > > > > It depends. When trying to add an alternate that doesn't exist we'll > > continue to print this error. But when such an alternate disappears > > after we have already added it to the object database then we indeed > > won't print this error anymore. > > > > I don't think this really is a huge issue by itself, as it feels > > sufficiently niche to not really matter, and the end result itself > > wouldn't change. But let me know in case you disagree. > > I don't disagree, but maybe the change deserves to be mentioned in the > commit message. Makes sense, will do. Patrick