From: Patrick Steinhardt Date: Tue, 27 Oct 2026 10:45:14 GMT Subject: Re: [PATCH v4 0/2] ci: fail the build if perforce, git-lfs or JGit fail to install Message-ID: In-Reply-To: On Tue, Oct 27, 2026 at 08:32:14AM +0000, Harald Nordgren via GitGitGadget wrote: > Fail the build when perforce, git-lfs, or JGit fail to install, and drop the > warnings that used to fire on every platform regardless of whether it even > attempted the install. > > Changes in v4: > > * Drops the && chaining between the wget/tar/chmod install steps for > perforce, git-lfs, and JGit, since under set -e a failing command inside > an && chain is exempt from aborting the script unless it's the last one > in the chain, so the chain was silently letting an earlier failure fall > through instead of stopping the build. > * Reworded the quarantine-removal commit to lead with the observation (the > call does nothing and can go) before the history, fixed a dangling "this" > reference, and added that the same holds on GitLab CI's macOS runners, > not just GitHub Actions. Thanks, this version looks good to me. Patrick