From: Patrick Steinhardt Date: Fri, 06 Nov 2026 11:02:32 GMT Subject: Re: [PATCH 0/5] Improvements for storage format handling Message-ID: In-Reply-To: On Fri, Nov 06, 2026 at 02:41:41AM -0800, Karthik Nayak wrote: > Patrick Steinhardt writes: > > > Hi, > > > > this patch series includes a couple of improvements for how we handle > > ref and object storage formats. > > > > Most importantly, this series allows us to run tests with a different > > object storage backend via `GIT_TEST_DEFAULT_OBJECT_STORAGE_FORMAT=`. As > > we don't have an alternative backend, I also introduce the ability to > > specify a default object (and ref) storage format that carries a payload > > so that you can run all tests with "files://objdir", for example. That > > surfaces a bunch of tests that assume objects exist in ".git/objects". > > > > Overall it's a surprisingly small number of test failures, only 1105 out > > of 35000 tests fail. Fixing those is not part of this patch series, but > > we'll start upstreaming fixes once this lands. Such tests will either > > have to be adapted to use plumbing commands, or they'll need to be > > tagged with a prerequisite. It's going to be a bunch of work, but it's > > basically preparing for the introduction of alternative backends > > already. > > > > The series is built on top of 0ffa3e35c7c (The 15th batch, 2026-11-04) > > with ps/odb-object-storage-extension at 87a55d790ca (builtin/submodule: > > propagate "--object-storage-format=", 2026-10-27) merged into it. > > > > Thanks! > > > > Patrick > > > > This was a very easy read. I don't have much to add apart from a comment > on 1/5. But you can also leave it as is! Thanks Thanks for your review! I'd prefer to leave 1/5 as-is as explained in my reply there. Patrick