From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 23 Oct 2026 07:41:59 GMT
Subject: Re: [PATCH 4/5] refs: stop calling root refs pseudorefs
Message-ID: <atsPx0Wn9tyMzpCl@pks.im>
In-Reply-To: <20261022212903.177261-5-andy.koppe@gmail.com>

On Thu, Oct 22, 2026 at 10:28:52PM +0100, Andy Koppe wrote:
> Some messages and comments in the code still use "pseudoref" in its old
> sense of any ref outside of "refs/", whereas the glossary now calls
> those root refs and restricts pseudorefs to FETCH_HEAD and MERGE_HEAD.
> 
> Replace "pseudoref" with "root ref" in the help text for
> "git for-each-ref --include-root-refs", in comments in refs.h, and in
> comments in the bash completion script, including the one for
> __git_pseudoref_exists(), which is also used for root refs.

I feel like this sentence is somewhat pointless, as you basically
just explain the diff.

> The function
> itself is not renamed. There is no obvious term covering both root refs
> and pseudorefs, and the old name might need to be kept for third-party
> completion scripts.

This is useful though.

> Update the description of pseudorefs in refs.h to match the glossary.

And this is again info that can simply be dropped.

Patrick