From: Patrick Steinhardt Date: Wed, 21 Oct 2026 05:45:23 GMT Subject: Re: What's cooking in git.git (Oct 2026, #06) Message-ID: In-Reply-To: <20261020185101.GA6367@tb-raspi4> On Tue, Oct 20, 2026 at 08:51:01PM +0200, Torsten Bögershausen wrote: > > * ps/pack-check-bigfile-threshold (2026-10-14) 1 commit > > - pack-check: fix bogus corruption report with core.bigFileThreshold > > > > That does fail here - the read-only files was not overwritten. > Patrick, can we get this extra line ? > > diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 16cc5d5dcb..a19bb27db7 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -544,6 +544,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' ' cd truncated-blob && blob=$(test-tool genrandom one 5k | git hash-object -t blob -w --stdin) && obj=.git/objects/$(test_oid_to_path $blob) && + chmod +w $obj && # Truncate the loose blob such that its header can still be # parsed, but reading the object data fails mid-stream. This diff is quite mangled, let me untangle it: diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 16cc5d5dcb..a19bb27db7 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -544,6 +544,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' ' cd truncated-blob && blob=$(test-tool genrandom one 5k | git hash-object -t blob -w --stdin) && obj=.git/objects/$(test_oid_to_path $blob) && + chmod +w $obj && # Truncate the loose blob such that its header can still be # parsed, but reading the object data fails mid-stream. Ah, right, that makes sense. Makes me wonder why none of our tests in CI hit this error. Weird. Junio, as this patch series is already in "next", do you want me to send a patch on top to fix it or shall I send a new version? Thanks for the report! Patrick