From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 19 Oct 2026 05:57:10 GMT
Subject: Re: [PATCH v2] refs/files: keep root refs out of loose ref cache
Message-ID: <atWxNvZn3CYTBuFp@pks.im>
In-Reply-To: <20261017200405.2332914-1-andy.koppe@gmail.com>

On Sat, Oct 17, 2026 at 09:04:00PM +0100, Andy Koppe wrote:
> Changes since v1:
> - Move create_root_ref_cache() below get_loose_ref_cache() for a smaller
>   diff, and tweak its comment.
> - Correct the documentation, help text and refs.h comment for
>   `--include-root-refs`, which claimed that it lists pseudorefs.
> - Consider alternative approaches in the log message.

It would help to also get a range-diff relative to v1 so that a reviewer
can see what exxactly has changed between the two versions.

> diff --git a/Documentation/for-each-ref-options.adoc b/Documentation/for-each-ref-options.adoc
> index 54e2fa95c2..b93ffbd74d 100644
> --- a/Documentation/for-each-ref-options.adoc
> +++ b/Documentation/for-each-ref-options.adoc
> @@ -73,7 +73,8 @@ TAB %(refname)`.
>  	using the same rules as _<pattern>_ above.
>  
>  `--include-root-refs`::
> -	List root refs (`HEAD` and pseudorefs) apart from regular refs.
> +	List root refs such as `HEAD` and `ORIG_HEAD` in addition to regular
> +	refs. (The pseudorefs `FETCH_HEAD` and `MERGE_HEAD` are not included.)
>  
>  `--start-after=<marker>`::
>      Allows paginating the output by skipping references up to and including the

These changes make sense, but they are unrelated to the fix. They should
thus go into a separate commit.

Patrick