From: Patrick Steinhardt Date: Mon, 19 Oct 2026 06:16:11 GMT Subject: Re: [PATCH v4 3/8] ci: drop unused "linux-clang" logic Message-ID: In-Reply-To: On Fri, Oct 16, 2026 at 08:33:57AM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > >> On some digging, it seems that 32d5b90590 (Enable Rust by default, > >> 2026-04-09) flipped Rust flags of CI jobs and retained NO_RUST only for this > >> job and the linux-musl-meson jobs. That means, we've been having the NO_RUST > >> flag on a Makefile based job that never existed in the first place which is > >> a bit sad. I wonder if we need to fix the intention at least now and slip > >> the NO_RUST flag into one of the other Makefile based jobs? > >> linux-feature-testbed? Or have a separate job for this? > >> > >> Of course, this is not really a problem with this series per se. So, we can > >> handle it separately if that's preferred. > > > > Yeah, we probably should fix this. But same as with the other things > > that we could do while at it I'd prefer to do those in a subsequent > > patch series. > > I would consider resurrecting the no-rust job is in the same spirit > as 8/8 to ensure test coverage for reftable by shuffling jobs > around. I do not mind seeing it done separately, but it is not too > big an effort to throw it into the feature testbed or linux32 job > just to make sure the system builds without rust, and doing so now > would mean we won't forget. And it is only until rust becomes > required anyway. It's not, but I've already got a subsequent patch series anyway where I'm following up on some of the related topics that were raised in this thread. I've queued the change as part of that follow-up. Patrick