From: Patrick Steinhardt Date: Mon, 19 Oct 2026 06:14:51 GMT Subject: Re: [PATCH v2 4/4] object-file: write ".keep" lockfiles during transaction commit Message-ID: In-Reply-To: <20261016213716.593278-5-jltobler@gmail.com> On Fri, Oct 16, 2026 at 04:37:16PM -0500, Justin Tobler wrote: > The "files" ODB backend writes a ".keep" lockfile into the transaction > quarantine directory via `odb_transaction_files_write_pack()`. When the > ODB transaction is committed, the ".keep" lockfile is migrated to the > primary ODB alongside its packfile. Writing the temporary lockfile in > this manner has a couple of downsides: > > - Migrating quarantined objects via `tmp_objdir_migrate()` doesn't > immediately stop if a ".keep" lockfile already exists for the same > packfile in the primary ODB and instead allows all the remaining > objects to be migrated. So even though `odb_transaction_commit()` > ultimately returns an error here, the objects are needlessly written > to the primary ODB anyways. Thanks, this is a lot clearer now. Patrick