From: Patrick Steinhardt Date: Thu, 15 Oct 2026 15:52:24 GMT Subject: Re: [PATCH v5 1/1] repo: add filtering options to "repo structure" Message-ID: In-Reply-To: On Thu, Oct 15, 2026 at 10:44:13AM -0400, Mark C. Chu-Carroll wrote: > On Wed Oct 14, 2026 at 8:15 AM EDT, Patrick Steinhardt wrote: > > On Tue, Oct 13, 2026 at 01:28:51PM -0400, Mark C. Chu-Carroll wrote: > >> diff --git a/t/t1901-repo-structure.sh b/t/t1901-repo-structure.sh > >> index 02cc2b594a..1d25ee14e5 100755 > >> --- a/t/t1901-repo-structure.sh > >> +++ b/t/t1901-repo-structure.sh > >> @@ -140,10 +140,208 @@ test_expect_success SHA1 'repository with references and objects' ' > >> @@ -186,13 +384,13 @@ test_expect_success SHA1 'lines and nul format' ' > > > > I'd drop these while-at-it changes. If you want to include them they > > should be part of a preparatory commit. > > Will drop. My reflex is to change all instances of something after > a comment like this. I think that's not the worst reflex to have, but in that case those should go into a preparatory commit. Patrick