From: Patrick Steinhardt Date: Mon, 26 Oct 2026 11:53:48 GMT Subject: Re: [PATCH v3 3/7] setup: allow overriding object storage format via environment Message-ID: In-Reply-To: On Mon, Oct 26, 2026 at 04:25:11AM -0700, Karthik Nayak wrote: > Patrick Steinhardt writes: > > diff --git a/setup.c b/setup.c > > index 249bd67876..70aa90a9cb 100644 > > --- a/setup.c > > +++ b/setup.c > > @@ -2097,6 +2098,21 @@ const char *setup_git_directory_gently(struct repository *repo, int *nongit_ok) > > die(_("unknown ref storage format: '%s'"), ref_backend_uri); > > } > > > > + /* > > + * Likewise, the GIT_OBJECT_STORAGE_FORMAT environment > > Really nitpicking today: I would drop the 'Likewise' here as this binds > this section of the code to the previous, which may not stay the same > over time. Fair, can do. Patrick