From: Patrick Steinhardt Date: Mon, 26 Oct 2026 08:58:52 GMT Subject: Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install Message-ID: In-Reply-To: On Mon, Oct 26, 2026 at 10:13:26AM +0200, Harald Nordgren wrote: > On Mon, Oct 26, 2026 at 10:07 AM Patrick Steinhardt wrote: > > > > On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote: > > > > > @@ -121,9 +133,16 @@ macos-*) > > > > > > > > > > mkdir -p "$CUSTOM_PATH" > > > > > wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" && > > > > > - tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d && > > > > > + tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d || { > > > > > + echo >&2 "error: could not install perforce" > > > > > + exit 1 > > > > > + } > > > > > sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true > > > > > > > > This line is a bit curious, it makes me wonder whether we want to > > > > tighten it as well now. Any reason why we wouldn't? > > > > > > I asked Claud about it and it said this, does it make sense? > > > > > > 'wget/curl never set com.apple.quarantine in the first place (only > > > Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so > > > xattr -d on these files always fails with "No such xattr." Tightening > > > it to fatal would break every macOS build, every time.' > > > > Well, if so we should be able to remove it without any detriment, right? > > Maybe that could be part of a preparatory patch. > > Best way to find out is just to do it, I guess. I can include it in v3 > and then you can trigger a build on GitLab with it? I'll let GitHub CI > pass before pushing anything out. Sounds good, thanks. Patrick