From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 26 Oct 2026 08:48:11 GMT
Subject: Re: [PATCH v2 0/5] stash completion miscellany
Message-ID: <at8TywNz2WcDc-0c@pks.im>
In-Reply-To: <cover.1792761643.git.ben.knoble@gmail.com>

On Fri, Oct 23, 2026 at 09:20:50AM -0400, D. Ben Knoble wrote:
> Diff-intervalle contre v1 :
> 1:  d0e461a14a ! 1:  90d36b6445 completion: simplify stash subcommand completion
>     @@ Commit message
>          The stash completion helper contains a hard-coded list of commands, but
>          git-stash provides a mechanism to list such commands
>          (--git-completion-helper). The pattern for using it is wrapped by
>     -    __git_resolve_builtins, so use it, bring _git_stash closer in line with
>     -    other completion helpers.
>     +    __git_resolve_builtins, so use it, bringing _git_stash closer in line
>     +    with other completion helpers. As a nice side-benefit, this also adds
>     +    "store" subcommand completion, which is missing from the explicit list
>     +    of subcommands.

Yup.

>     -    Note that we maintain the "save" special case, since it was removed from
>     +    Note that we maintain the "save" special case†, since it was removed from
>          default completion in 0eb5a4f911 (completion: stop showing 'save' for
>     -    stash by default, 2018-04-20). We don't have to do anything special with
>     -    the exclude (3rd) argument to __git_resolve_builtins, though, because
>     -    save is already marked PARSE_OPT_NOCOMPLETE.
>     +    stash by default, 2018-04-20). One might think we need to give "save" to
>     +    __git_resolve_builtins' 3rd exclude argument to prevent it from
>     +    showing up, but we don't: "save" is already marked PARSE_OPT_NOCOMPLETE.
>     +
>     +    †We don't complete the "save" subcommand unless at least "sa" has been
>     +    typed, but we do complete its options if explicitly typed. With this
>     +    change, we will complete "save" if GIT_COMPLETION_SHOW_ALL=1.

Good.

> 5:  d1d0bf2d9a ! 5:  0266646fb4 completion: drop "stash save" completion altogether
>     @@ Commit message
>          further documentation suggesting to use it.
>      
>          Since we recommend push instead, stop completing for "save" and remove a
>     -    special case in completion code.
>     +    special case in completion code. It still appears for "git stash <tab>"
>     +    when GIT_COMPLETION_SHOW_ALL=1, and when typed explicitly we still
>     +    complete options for
>     +
>     +        git stash save --<tab>
>     +
>     +    which is helpful for folks with finger-memory for save.

Agreed, documenting the status quo feels reasonable to me.

So overall I'm happy with this v2, thanks!

Patrick