From: Patrick Steinhardt Date: Mon, 26 Oct 2026 08:02:43 GMT Subject: Re: [PATCH v2] ci: drop no-op gettext link on macOS Message-ID: In-Reply-To: On Mon, Sep 14, 2026 at 07:09:09AM +0000, Harald Nordgren via GitGitGadget wrote: > From: Harald Nordgren > > Homebrew's gettext formula used to be keg-only, meaning brew would > install it into the Cellar without linking its headers, libraries, or > utilities like msgfmt anywhere on the default search paths, to avoid > clashing with software that already ships its own gettext. `brew link > --force gettext` overrode that restriction so the keg-only install > became visible on the paths git's build and tests rely on. > > Homebrew dropped gettext's keg-only status in 2020 > (https://github.com/Homebrew/homebrew-core/pull/53489), so a fresh > install now links into the prefix by itself. `brew link --force` > against an already-linked keg has nothing left to override, and only > produces a spurious "Already linked" warning in every macOS job's > log. Thanks, that's useful context to have and explains why it's fine to remove this now. > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index 2f61fbb07c..2903c39fab 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -117,7 +117,6 @@ macos-*) > export HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1 > # Uncomment this if you want to run perf tests: > # brew install gnu-time > - brew link --force gettext Okay. Your [1] verifies that this works on the GitHub side. I've also created a pipeline on the GitLab side in [2], and that pipeline passes, as well. So overall this change looks reasonable to me, thanks! Patrick [1]: https://github.com/git/git/pull/2402 [2]: https://gitlab.com/gitlab-org/git/-/merge_requests/713