From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 06 Oct 2026 12:23:55 GMT
Subject: Re: [PATCH] t0450: use test_path_is_file and test_path_is_missing
Message-ID: <asToW_aXYGCg0xuv@pks.im>
In-Reply-To: <20261006101458.604775-1-dilsheddilu123@gmail.com>

On Tue, Oct 06, 2026 at 03:44:58PM +0530, Muhammed Dilshad A wrote:
> Replace raw 'test -f' and '! test -f' assertions with the test helper
> functions 'test_path_is_file' and 'test_path_is_missing' to provide
> diagnostic output when an assertion fails.
> 
> Signed-off-by: Muhammed Dilshad A <dilsheddilu123@gmail.com>

Good commit message, pinpointing exactly why we even bother to do this
change.

> diff --git a/t/t0450-txt-doc-vs-help.sh b/t/t0450-txt-doc-vs-help.sh
> index 55c0fb3cb7..a2da2b0192 100755
> --- a/t/t0450-txt-doc-vs-help.sh
> +++ b/t/t0450-txt-doc-vs-help.sh
> @@ -116,13 +116,13 @@ do
>  	if grep -q "^$builtin$" "$TEST_DIRECTORY"/t0450/adoc-missing
>  	then
>  		test_expect_success "$builtin appropriately marked as not having .adoc" '
> -			! test -f "$adoc"
> +			test_path_is_missing "$adoc"
>  		'
>  	else
>  		test_set_prereq "$preq"
>  
>  		test_expect_success "$builtin appropriately marked as having .adoc" '
> -			test -f "$adoc"
> +			test_path_is_file "$adoc"
>  		'
>  	fi

And the change looks obviously good to me, as well. Thanks!

Patrick