From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 06 Oct 2026 05:53:27 GMT
Subject: Re: [PATCH] builtin/repo: rename "references.format" to "references.storageFormat"
Message-ID: <asSM12B35oka08Nu@pks.im>
In-Reply-To: <CAOLa=ZTNNY_XuixqZ96TK0zFfDpWvxSupxVGOnH1VGXK4KF_0w@mail.gmail.com>

On Mon, Oct 05, 2026 at 03:11:19PM +0000, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)
> > we have adapt all sites that used to say "reference format" to instead
> > say "reference storage format".
> >
> > One missed spot though was in git-repo(1), where we still print the
> > "references.format" key. Fix that oversight by renaming the key to
> > "references.storageFormat".
> 
> The patch looks good, but this does break backward compatibility. But
> since the command it marked as experimental, this should be okay.

Right, I should've probably mentioned this as part of the commit
message. We could for a while carry both keys of course. But given that
it's marked as experimental I think it's okay to break the format and
drop the old key.

Thanks!

Patrick