From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 30 Sep 2026 12:05:33 GMT
Subject: Re: [PATCH 3/3] refs/reftable: fix on-disk representation of reflog timezones
Message-ID: <arz7DV44Au08oLad@pks.im>
In-Reply-To: <CAOLa=ZQorPk_Kkewkw5k-gdeh=VRVBMcaDA54S0ByJfAswcCWQ@mail.gmail.com>

On Wed, Sep 30, 2026 at 04:51:15AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
> > index 35e98b43db..579657467d 100755
> > --- a/t/t0610-reftable-basics.sh
> > +++ b/t/t0610-reftable-basics.sh
> > @@ -837,6 +837,41 @@ test_expect_success 'reflog: renaming branch writes reflog entry' '
> >  	)
> >  '
> >
> > +test_expect_success 'reflog: timezone offset is stored in minutes' '
> > +	test_when_finished "rm -rf repo" &&
> > +	git init repo &&
> > +	(
> > +		cd repo &&
> > +		GIT_COMMITTER_DATE="1234567890 -1200" git commit --allow-empty -m min &&
> > +		GIT_COMMITTER_DATE="1234567890 +0530" git commit --allow-empty -m east &&
> > +		GIT_COMMITTER_DATE="1234567890 -0800" git commit --allow-empty -m west &&
> > +		GIT_COMMITTER_DATE="1234567890 +1400" git commit --allow-empty -m max &&
> 
> Nit: it would be nice to have a negative timezone with MM filled in too.

Sure, can do. I'll just change -0800 to -0830. Thanks!

Patrick